Messages in this thread | | | Date | Fri, 29 Aug 2008 14:43:20 +0100 | Subject | Definition of PIM_REGISTER in pim.h, with more information | From | Jose Calhariz <> |
| |
I am sending this email again because I have more information.
----- Forwarded message from cal -----
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Cc: Claudio Martins <ctpm@ist.utl.pt>, Jorge Daniel Sequeira Matias <martin@andorinha.ist.utl.pt>, javifs@gmail.com Subject: Definition of PIM_REGISTER in pim.h
Hi.
About the new file linux/pim.h and the definitions of PIM in linux 2.6.26.
The "#define PIM_REGISTER 1" was in file mroute.h and was protected by "#ifdef __KERNEL__" until version 2.5.25. In version 2.6.26 this define is in file pim.h but is no longer protected by a "#ifdef __KERNEL__".
Is this change intentional?
This change breaks the compilation of software from the project www.xorp.org. In the file mrt/include/netinet/pim.h for the xorp software they define PIM messages types and use this code:
/* * PIM message types */ #define PIM_HELLO 0x0 /* PIM-SM and PIM-DM */
#define PIM_REGISTER 0x1 /* PIM-SM only */
#define PIM_REGISTER_STOP 0x2 /* PIM-SM only */ #define PIM_JOIN_PRUNE 0x3 /* PIM-SM and PIM-DM */ #define PIM_BOOTSTRAP 0x4 /* PIM-SM only */ #define PIM_ASSERT 0x5 /* PIM-SM and PIM-DM */ #define PIM_GRAFT 0x6 /* PIM-DM only */ #define PIM_GRAFT_ACK 0x7 /* PIM-DM only */ #define PIM_CAND_RP_ADV 0x8 /* PIM-SM only */ #define PIM_ALL_DF_ELECTION 0xa /* Bidir-PIM-SM only */
You can see the bug report with more details in:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494223
I am one of the two persons that is packaging xorp for Debian. I am talking in my personal name, not in the name of Debian, xorp project or employer. I am asking this to you because the problematic change was possible introduced by:
commit 2e8046271f68198dd37451017c1a4a2432e4ec68 Author: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Date: Thu Apr 3 09:22:09 2008 +0900
[IPV4] MROUTE: Move PIM definitions to <linux/pim.h>. Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
I am free to give you more information if you need. I am sorry if any of my facts is wrong.
José Calhariz
--------------
The bug report for xorp.org is in http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=767 and they have found a solution. But I still believe the bug is on Linux Kernel Headers.
José Calhariz
--
As palavras enchem o espaço. Eu prefiro encher a carteira
--Andy Warhol [unhandled content-type:application/pgp-signature]
| |