lkml.org 
[lkml]   [2008]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpiolib: Allow user-selection
On Sun, Jul 06, 2008 at 10:01:24PM +0200, Michael Buesch wrote:
> On Sunday 06 July 2008 21:52:12 Adrian Bunk wrote:
>...
> So well. I'm not sure what you're talking about. Care to make
> a better helptext?

Sorry, the problem wasn't the help text but me being blind.

Please ignore my comment.

> > > --- linux-next.orig/arch/arm/configs/am200epdkit_defconfig 2008-07-03 11:31:05.000000000 +0200
> > > +++ linux-next/arch/arm/configs/am200epdkit_defconfig 2008-07-03 11:36:14.000000000 +0200
> > > @@ -668,7 +668,7 @@
> > > #
> > > # CONFIG_SPI is not set
> > > # CONFIG_SPI_MASTER is not set
> > > -CONFIG_HAVE_GPIO_LIB=y
> > > +CONFIG_ARCH_REQUIRE_GPIOLIB=y
> > >...
> >
> > Please don't do this kind of defconfig updates - it doesn't bring any
> > advantage but can create tons of patch conflicts.
> >
> > The next time a defconfig gets updated it will anyway automatically be
> > fixed, and for defconfigs that aren't updated it doesn't create any
> > problems to keep them as they are today until they might one day get
> > updated.
>
> So will the auto-regenerated defconfig result in CONFIG_ARCH_REQUIRE_GPIOLIB=y
> or CONFIG_ARCH_REQUIRE_GPIOLIB=n? I thought it would result in =n, as the
> option defaults to n. So I changed all defconfigs.
>
> (I think these (sub)archs should "select" the option in their Kconfig, but I
> didn't want to go down that way).

A defconfig is just a normal .config and cannot override any dependencies.

CONFIG_ARCH_REQUIRE_GPIOLIB is not user visible and defaults to n, so if
no option select's it then even using a defconfig that has it enabled
will result in a .config that has it disabled.

> Greetings Michael.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-07-06 22:17    [W:0.038 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site