lkml.org 
[lkml]   [2008]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] gpiolib: Allow user-selection
Date
On Sunday 06 July 2008 21:52:12 Adrian Bunk wrote:
> > +menuconfig GPIOLIB
> > + bool "GPIO Support"
> > + depends on ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB
> > + select GENERIC_GPIO
> > + help
> > + This enables GPIO support through the generic GPIO library.
> > + You only need to enable this, if you also want to enable
> > + one or more of the GPIO expansion card drivers below.
> > +
> > + If unsure, say N.
> >...
>
> The implementation of ARCH_REQUIRE_GPIOLIB does not match the description.
>
> Matching the description would be:
>
> menuconfig GPIOLIB
> bool "GPIO Support" if !ARCH_REQUIRE_GPIOLIB
> depends on ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB
> default ARCH_REQUIRE_GPIOLIB
> select GENERIC_GPIO
> help
> ...

So well. I'm not sure what you're talking about. Care to make
a better helptext?

> > --- linux-next.orig/arch/arm/configs/am200epdkit_defconfig 2008-07-03 11:31:05.000000000 +0200
> > +++ linux-next/arch/arm/configs/am200epdkit_defconfig 2008-07-03 11:36:14.000000000 +0200
> > @@ -668,7 +668,7 @@
> > #
> > # CONFIG_SPI is not set
> > # CONFIG_SPI_MASTER is not set
> > -CONFIG_HAVE_GPIO_LIB=y
> > +CONFIG_ARCH_REQUIRE_GPIOLIB=y
> >...
>
> Please don't do this kind of defconfig updates - it doesn't bring any
> advantage but can create tons of patch conflicts.
>
> The next time a defconfig gets updated it will anyway automatically be
> fixed, and for defconfigs that aren't updated it doesn't create any
> problems to keep them as they are today until they might one day get
> updated.

So will the auto-regenerated defconfig result in CONFIG_ARCH_REQUIRE_GPIOLIB=y
or CONFIG_ARCH_REQUIRE_GPIOLIB=n? I thought it would result in =n, as the
option defaults to n. So I changed all defconfigs.

(I think these (sub)archs should "select" the option in their Kconfig, but I
didn't want to go down that way).

--
Greetings Michael.


\
 
 \ /
  Last update: 2008-07-06 22:05    [W:0.061 / U:3.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site