Messages in this thread | | | Date | Sun, 6 Jul 2008 09:01:38 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCH] parport/ppdev: fix registration of sysctl entries |
| |
On Sun, 6 Jul 2008 17:07:02 +0200 Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> On Sun, Jul 06, 2008 at 01:11:48AM +0100, Al Viro wrote: > > On Sun, Jul 06, 2008 at 12:51:48AM +0100, Al Viro wrote: > > > > > I don't believe that it's right. Note that if you *do* race > > > there, you are fucked regardless of sysctls - > > > ppdev.c::register_device() racing with itself will do tons of fun > > > things all by itself (starting with two threads allocating > > > different pdev and both setting pp->pdev). > > I wouldn't call it a race - BKL is protecting multiple ioctl calls, > so we won't ever claim the device from two different threads.
eh... there's sleeping functions in there.. the BKL doesn't protect you squat ;)(
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |