Messages in this thread | | | Date | Sun, 6 Jul 2008 17:07:02 +0200 | From | Marcin Slusarz <> | Subject | Re: [PATCH] parport/ppdev: fix registration of sysctl entries |
| |
On Sun, Jul 06, 2008 at 01:11:48AM +0100, Al Viro wrote: > On Sun, Jul 06, 2008 at 12:51:48AM +0100, Al Viro wrote: > > > I don't believe that it's right. Note that if you *do* race there, you > > are fucked regardless of sysctls - ppdev.c::register_device() racing > > with itself will do tons of fun things all by itself (starting with two > > threads allocating different pdev and both setting pp->pdev).
I wouldn't call it a race - BKL is protecting multiple ioctl calls, so we won't ever claim the device from two different threads.
> BTW, with your patch you'll have 100% reproducible double registration if > you do PPCLAIM/PPRELEASE/PPCLAIN on one file descriptor.
Yes, I didn't notice PPRELEASE ioctl (I thought releasing the device is done during close()).
| |