Messages in this thread Patch in this message | | | Date | Mon, 21 Jul 2008 09:57:47 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 3/7] drivers/net/wireless/b43legacy/main.c: Release mutex in error handling code |
| |
From: Julia Lawall <julia@diku.dk>
The mutex is released on a successful return, so it would seem that it should be released on an error return as well.
The semantic patch finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression l; @@
mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- diff -u -p a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c --- a/drivers/net/wireless/b43legacy/main.c +++ b/drivers/net/wireless/b43legacy/main.c @@ -3862,10 +3862,10 @@ static int b43legacy_resume(struct ssb_d goto out; } } - mutex_unlock(&wl->mutex); b43legacydbg(wl, "Device resumed.\n"); out: + mutex_unlock(&wl->mutex); return err; }
| |