Messages in this thread | | | Date | Tue, 15 Jul 2008 16:24:41 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/7] dynamic debug v2 - nfs conversion |
| |
On Tue, 15 Jul 2008 19:15:45 -0400 Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> On Tue, 2008-07-15 at 18:56 -0400, Trond Myklebust wrote: > > > The point is that he is changing a semi-official interface for tracing > > the NFS kernel activity from userspace. I'd like to know why and how it > > is being modified before I can ack it. > > > > In addition there are several other developers who have a daily interest > > in using this interface when helping our users, and who might have > > comments. > > OK. Having looked up the missing patch on gmane, I'd like to know > whether or not there is a followup plan to fix up utilities like > 'rpcdebug'? Apparently this patch doesn't remove the existing sunrpc > sysctl interface, but does circumvent it. The result is that while > rpcdebug will happily continue to run, it just won't work any more... >
I'm suspecting that Jason chose the wrong starter subsystem here ;) Probably we should have started with the many hundreds of simpler cases.
OTOH, it's important that Jason understand NFS's requirements here. Treat it as a testcase for his design. Will his infrastructure be usable by NFS? If not, does his infrastructure need generalising and strengthening so that it _does_ suit?
| |