Messages in this thread | | | Subject | Re: [PATCH 2/7] dynamic debug v2 - nfs conversion | From | Trond Myklebust <> | Date | Tue, 15 Jul 2008 18:56:07 -0400 |
| |
On Tue, 2008-07-15 at 15:43 -0700, Andrew Morton wrote: > On Tue, 15 Jul 2008 18:30:03 -0400 > Trond Myklebust <trond.myklebust@fys.uio.no> wrote: > > > On Tue, 2008-07-15 at 17:32 -0400, Jason Baron wrote: > > > -convert sunrpc debug facility > > > > > > Signed-off-by: Jason Baron <jbaron@redhat.com> > > > > > > > Where the hell did this come from, what's its purpose, and WTF haven't > > you Cced linux-nfs@vger.kernel.org so that the rest of us can review it? > > It's on linux-kernel. If you don't have a linux-kernel subscription > then you should fix that. Set up a procmail rule and do a > search-by-subject when needed.
I get my daily share of 1000-odd mails from linux-kernel, thanks, but 99% of that goes into the trashcan. I only keep a mail if I see that it's relevant. In this case, 1 email out of 7 turns out to be relevant (after I inadvertently deleted the apparently crucial first 2 emails), and there is no changelog entry to tell me what's being done or why.
By Ccing the correct list, we at least get a heads-up that this thread might be important. I can't archive all of lkml on my laptop, but I can and do archive all of linux-nfs...
> In this case, yes, it would have been nice if Jason had cc'ed lots of > different lists and individuals on the core patch and then selectively > cc'ed lists and individuals on the per-subsystem followup patches. But > I doubt if even 2% of patch submitters manage to do all that correctly.
The point is that he is changing a semi-official interface for tracing the NFS kernel activity from userspace. I'd like to know why and how it is being modified before I can ack it.
In addition there are several other developers who have a daily interest in using this interface when helping our users, and who might have comments.
Trond
| |