Messages in this thread Patch in this message | | | Date | Thu, 5 Jun 2008 20:49:38 +0200 (CEST) | From | Stefan Richter <> | Subject | [PATCH] firewire: fw-ohci: disable PHY packet reception into AR context |
| |
We want the rcvPhyPkt bit in LinkControl off before we start using the chip. However, the spec says that the reset value of it is undefined. Hence switch it explicitly off.
https://bugzilla.redhat.com/show_bug.cgi?id=244576#c48 shows that for example the nForce2 integrated FireWire controller seems to have it on by default.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> ---
Supersedes patch "fw-ohci: clear LinkControl register when enabling the chip". Changed from ~0 to OHCI1394_LinkControl_rcvPhyPkt bit only.
drivers/firewire/fw-ohci.c | 2 ++ 1 file changed, 2 insertions(+)
Index: linux/drivers/firewire/fw-ohci.c =================================================================== --- linux.orig/drivers/firewire/fw-ohci.c +++ linux/drivers/firewire/fw-ohci.c @@ -1473,6 +1473,8 @@ static int ohci_enable(struct fw_card *c reg_write(ohci, OHCI1394_HCControlClear, OHCI1394_HCControl_noByteSwapData); + reg_write(ohci, OHCI1394_LinkControlClear, + OHCI1394_LinkControl_rcvPhyPkt); reg_write(ohci, OHCI1394_LinkControlSet, OHCI1394_LinkControl_rcvSelfID | OHCI1394_LinkControl_cycleTimerEnable | -- Stefan Richter -=====-==--- -==- --=-= http://arcgraph.de/sr/
| |