Messages in this thread | | | Subject | Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID | From | Kristian Høgsberg <> | Date | Fri, 13 Jun 2008 09:50:14 -0400 |
| |
On Thu, 2008-06-05 at 20:50 +0200, Stefan Richter wrote: > OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is > written into LinkControl.rcvSelfID. > > This driver bug has so far not been known to cause harm because most > chips obviously accept a later selfIDBufferPtr write. > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Yeah, good point. I think it also caused no harm because we set it up before enabling the link. But your change definitely looks good.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |