Messages in this thread | | | Date | Thu, 26 Jun 2008 17:15:52 +0300 | From | Adrian Bunk <> | Subject | Re: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users |
| |
On Thu, Jun 26, 2008 at 03:23:21PM +0200, Haavard Skinnemoen wrote: > This makes the DMA Engine menu visible on AVR32 by adding AVR32 to the > (growing) list of architectures DMADEVICES depends on. Though I'd prefer > to remove that whole "depends" line entirely... > > The DMADEVICES menu used to be available for all architectures, but at > some point, we started building a huge dependency list with all the > architectures that might have support for this kind of hardware. > > According to Dan Williams: > > > Adrian had concerns about users enabling NET_DMA when the hardware > > capability is relatively rare. > > which seems very strange as long as (PCI && X86) is enough to enable > this menu. In other words, the vast majority of users will see the menu > even though the hardware is rare. > > Also, all DMA clients depend on DMA_ENGINE being set. This symbol is > selected by each DMA Engine driver, so users can't select a DMA client > without selecting a specific DMA Engine driver first. >...
That discussion is mixing two different things I suggested besides other things before the Kconfig file was added [1]: - have DMA_ENGINE select'ed when a device gets enabled by the user, and not be an independent option - switch to menuconfig and don't offer an empty kconfig menu
There seems to be no disagreement about the former (which could otherwise easily lead to users mistakenly enabling NET_DMA).
The latter is more a cosmetical kconfig UI thing, and I already said back then that it "could be dropped if it would become a problem" [2].
So if you want to remove the architecture dependency from the DMADEVICES menu that's OK with me.
cu Adrian
[1] http://lkml.org/lkml/2007/7/26/15 [2] http://lkml.org/lkml/2007/8/9/537
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |