lkml.org 
[lkml]   [2008]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users
Date
This makes the DMA Engine menu visible on AVR32 by adding AVR32 to the
(growing) list of architectures DMADEVICES depends on. Though I'd prefer
to remove that whole "depends" line entirely...

The DMADEVICES menu used to be available for all architectures, but at
some point, we started building a huge dependency list with all the
architectures that might have support for this kind of hardware.

According to Dan Williams:

> Adrian had concerns about users enabling NET_DMA when the hardware
> capability is relatively rare.

which seems very strange as long as (PCI && X86) is enough to enable
this menu. In other words, the vast majority of users will see the menu
even though the hardware is rare.

Also, all DMA clients depend on DMA_ENGINE being set. This symbol is
selected by each DMA Engine driver, so users can't select a DMA client
without selecting a specific DMA Engine driver first.

So, while this patch solves my immediate problem of making DMA Engines
available on AVR32, I'd much rather remove the whole arch dependency
list because I think it's bogus. Comments?

Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Adrian Bunk <bunk@stusta.de>
---
drivers/dma/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 18f6ef3..2ac09be 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -4,7 +4,7 @@

menuconfig DMADEVICES
bool "DMA Engine support"
- depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || PPC
+ depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || PPC || AVR32
depends on !HIGHMEM64G
help
DMA engines can do asynchronous data transfers without
--
1.5.5.4


\
 
 \ /
  Last update: 2008-06-26 15:33    [W:0.127 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site