Messages in this thread | | | Date | Sun, 22 Jun 2008 12:38:38 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks |
| |
On Sun, Jun 22, 2008 at 7:22 AM, Paul Jackson <pj@sgi.com> wrote: > From: Paul Jackson <pj@sgi.com> > > Page frame numbers (the portion of physical addresses above the low > order page offsets) are displayed in several kernel debug and info > prints in decimal, not hex. Decimal addresse are unreadable. Use hex. > > Signed-off-by: Paul Jackson <pj@sgi.com> > > --- > arch/x86/kernel/e820.c | 2 +- > arch/x86/mm/init_64.c | 2 +- > mm/page_alloc.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > > --- linux-next.orig/arch/x86/kernel/e820.c 2008-06-22 06:36:07.203937695 -0700 > +++ linux-next/arch/x86/kernel/e820.c 2008-06-22 06:36:16.792519156 -0700 > @@ -922,7 +922,7 @@ unsigned long __init e820_end_of_ram(voi > if (last_pfn > end_user_pfn) > last_pfn = end_user_pfn; > > - printk(KERN_INFO "last_pfn = %lu max_arch_pfn = %lu\n", > + printk(KERN_INFO "last_pfn = 0x%lx max_arch_pfn = 0x%lx\n",
we should remove 0x, and hex print out all the way...regarding mem pfn and memory address, memory size etc. except XXXMB. XXXKB...
YH
| |