Messages in this thread Patch in this message | | | Date | Sat, 21 Jun 2008 17:41:24 +0400 | From | Oleg Nesterov <> | Subject | [PATCH 1/2] get_user_pages: fix possible page leak on oom |
| |
get_user_pages() must not return the error when i != 0. When pages != NULL we have i get_page()'ed pages.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 26-rc2/mm/memory.c~1_GUP_OOM 2008-06-21 15:35:21.000000000 +0400 +++ 26-rc2/mm/memory.c 2008-06-21 15:56:58.000000000 +0400 @@ -1115,7 +1115,7 @@ int get_user_pages(struct task_struct *t * be processed until returning to user space. */ if (unlikely(test_tsk_thread_flag(tsk, TIF_MEMDIE))) - return -ENOMEM; + return i ? i : -ENOMEM; if (write) foll_flags |= FOLL_WRITE;
| |