lkml.org 
[lkml]   [2008]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_start/commit
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> +#define __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION
>>
>
> please turn this into CONFIG_ARCH_HAS_PTEP_MODIFY_PROT_TRANSACTION
> instead.

The __HAVE_ARCH_ form is consistent with all the other conditional
things in asm/pgtable.h, like __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS,
__HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG, etc. I don't think adding
CONFIG_ARCH_HAS_ for this one case is a good idea.

J


\
 
 \ /
  Last update: 2008-06-02 14:01    [W:0.115 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site