lkml.org 
[lkml]   [2008]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_
Date
On Monday 02 June 2008 23:02:34 Jeremy Fitzhardinge wrote:
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> include/asm-generic/pgtable.h | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> ===================================================================
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -201,9 +201,11 @@
> unsigned long addr,
> pte_t *ptep)
> {
> - /* Get the current pte state, but zero it out to make it
> - non-present, preventing the hardware from asynchronously
> - updating it. */
> + /*
> + * Get the current pte state, but zero it out to make it
> + * non-present, preventing the hardware from asynchronously
> + * updating it.
> + */

Since there is debate over whether winged comments are a feature, I'm not sure
this can be termed a "fix".

> {
> - /* The pte is non-present, so there's no hardware state to
> - preserve. */
> + /*
> + * The pte is non-present, so there's no hardware state to
> + * preserve.
> + */
> set_pte_at(mm, addr, ptep, pte);
> }

This will fit in one line, no?

Rusty.


\
 
 \ /
  Last update: 2008-06-03 01:49    [W:0.223 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site