lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 6/6] x86: add c1e aware idle function
On Thu, 12 Jun 2008, Andrew Morton wrote:
> On Thu, 12 Jun 2008 10:29:00 -0000
> Thomas Gleixner <tglx@linutronix.de> wrote:
> > + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &cpu);
> > + default_idle();
> > + local_irq_disable();
> > + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
> > + local_irq_enable();
>
> I worked it out! It took me a while.
>
> This function is called with local irqs disabled.
>
> default_idle() is entered with local irqs disabled but returns with them
> enabled.
>
> clockevents_notify() is supposed to be called with local irqs disabled.
>
> This functions returns with local irqs enabled.

Damn, you decoded my sekrit.

> Was I right? None of any of that is documented anywhere. But it should
> be.

Yeah, needs a big comment. Will add one.

Thanks,

tglx


\
 
 \ /
  Last update: 2008-06-13 08:05    [W:0.111 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site