Messages in this thread | | | Date | Thu, 8 May 2008 12:50:13 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 05/24] sysfs: dont call notify_change |
| |
On Tue, May 06, 2008 at 11:13:32AM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > sysfs_chmod_file() calls notify_change() to change the permission bits > on a sysfs file. Replace with explicit call to sysfs_setattr() and > fsnotify_change(). > > This is equivalent, except that security_inode_setattr() is not > called. This function is called by drivers, so the security checks do > not make any sense.
Looks correct to me, although I really don't see the point for it.
| |