lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tmpfs: support aio
On Wed, 28 May 2008, Andrew Morton wrote:
>
> hm. This version:
> is neater but generates 21 bytes more code. Stupid gcc.
>
> I don't believe we needed to check for count == 0? We'd just loop around
> N times doing nothing.

You're right, thanks, and that's hardly a path we need to optimize.
I was just blindly copying generic_file_aio_read, but they would
both benefit from your improvement. If you don't mind, I'll send
you a replacement patch for shmem.c, and a patch for filemap.c.

Hugh


\
 
 \ /
  Last update: 2008-05-29 20:25    [W:0.038 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site