lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tmpfs: support aio
From
Date
On Wed, 2008-05-28 at 16:58 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 00:13:35 +0100 (BST)
> Hugh Dickins <hugh@veritas.com> wrote:
> hm. This version:
>
> static ssize_t shmem_file_aio_read(struct kiocb *iocb,
> const struct iovec *iov, unsigned long nr_segs, loff_t pos)
> {
> struct file *filp = iocb->ki_filp;
> ssize_t retval;
> unsigned long seg;
> size_t count;
> loff_t *ppos = &iocb->ki_pos;
>
> count = 0;
> retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> if (retval)
> return retval;
> if (count == 0)
> return 0;
>
> retval = 0;

retval has to be 0 here, no need to assign it again?

Harvey



\
 
 \ /
  Last update: 2008-05-29 02:09    [W:0.063 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site