Messages in this thread Patch in this message | | | From | Christian Borntraeger <> | Subject | [Patch/RFC]: check CONFIG_GENERIC_HARDIRQS for request/free_irq in interrupt.h | Date | Thu, 29 May 2008 17:41:13 +0200 |
| |
I currently try to evaluate virtio_console for kvm on s390 and got the following problem:
virtio_console uses hvc_alloc with irq=0. That means, register_irq and free_irq are never called by hvc_console.c, but the linker will still complain about unknown references to free_irq and request_irq.
As the whole kernel/irq folder depends on CONFIG_GENERIC_HARDIRQS it seems consistent to declare all functions from kernel/irq only if CONFIG_GENERIC_HARDIRQS is set. Otherwise we can use empty functions.
This patch does that for register_irq and free_irq.
Comments?
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> CC: Ingo Molnar <mingo@elte.hu> CC: Thomas Gleixner <tglx@linutronix.de> CC: Martin Schwidefsky <schwidefsky@de.ibm.com> --- include/linux/interrupt.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Index: linux-2.6/include/linux/interrupt.h =================================================================== --- linux-2.6.orig/include/linux/interrupt.h +++ linux-2.6/include/linux/interrupt.h @@ -69,9 +69,22 @@ struct irqaction { }; extern irqreturn_t no_action(int cpl, void *dev_id); + +#ifdef CONFIG_GENERIC_HARDIRQS extern int __must_check request_irq(unsigned int, irq_handler_t handler, unsigned long, const char *, void *); extern void free_irq(unsigned int, void *); +#else +static inline int request_irq(unsigned int irq, irq_handler_t handler, + unsigned long irqflags, const char *devname, void *dev_id) +{ + return -EINVAL; +} + +static inline void free_irq(unsigned int irq, void *dev_id) +{ +} +#endif struct device;
| |