Messages in this thread | | | Date | Wed, 28 May 2008 16:37:31 -0400 | From | James Kosin <> | Subject | Re: optimizing out inline functions |
| |
Sam Ravnborg wrote: > On Wed, May 28, 2008 at 02:51:02PM -0500, Steve French wrote: >> In trying to remove some macros, I ran across another kernel style <<--SNIP-->> > With reference to a recent thread about kconfig > I would prefer: > static inline void some_debug_function(var1) > { > if (KCONFIG_DEBUG_SOMETHING) { > something = var1; > printk(some debug text); > } > } > > > But we do not have KCONFIG_DEBUG_SOMETHING available > so the second best is to use an empty function > to keep the typechecking in place. > > IIRC gcc optimize both away.
Another way would be to have:
static inline void some_debug_function(var1) { #ifdef KCONFIG_DEBUG_SOMETHING something = var1; printk(some debug text); #endif }
BUT, this probably violates some styling rules.
James }
| |