Messages in this thread | | | Subject | Re: [PATCH 1/3] firmware: allow firmware files to be built into kernel image | From | David Woodhouse <> | Date | Fri, 23 May 2008 16:25:20 +0100 |
| |
On Fri, 2008-05-23 at 17:19 +0200, Takashi Iwai wrote: > Hm, but request_firmware() returns the const pointer. It implies that > the caller shouldn't change the content, doesn't it? > > I cannot guarantee that there must be no misbehaving drivers, > though...
The 'struct firmware' is const. It contains a pointer to data. That data is not const.
fw->data = some_other_data; // bad. fw->data[0] = 0; // ok.
Of course, we could _make_ it const (if we can remember whether it's 'const u8 *' or 'u8 const *'...)
-- dwmw2
| |