Messages in this thread | | | Subject | Re: [PATCH 1/3] firmware: allow firmware files to be built into kernel image | From | David Woodhouse <> | Date | Fri, 23 May 2008 15:58:31 +0100 |
| |
On Fri, 2008-05-23 at 16:53 +0200, Takashi Iwai wrote: > This looks like a nice cleanup. It'd be nicer if we can skip vmalloc > and duplication of the image for static binaries.
Yeah, I thought about that. I was slightly concerned that drivers might actually try to _modify_ the firmware they loaded, though. As it is, there's no fundamental reason why they shouldn't do that.
If we're willing to declare that drivers mustn't write to the firmware data, then we could do as you suggest.
> BTW, is the dependency considered? FW_LOADER depends on HOTPLUG, and > the static loader shouldn't depend on HOTPLUG.
Ah, good point; I'll take a closer look at that. Thanks.
-- dwmw2
| |