Messages in this thread Patch in this message | | | Date | Fri, 23 May 2008 17:06:28 +0530 | From | Sharyathi Nagesh <> | Subject | correction to compat_sys_kexec_load |
| |
Hi While testing with kexec tool, I observed some problems. When application (kexec) is 32 bit and kernel is 64 bit I observed that loading crash kernel works without any issues but unloading crash kernel fails. -------------------------------------------------------- running strace over 'kexec -u -p' show the problem to be with sys_kexec_load() call
sys_kexec_load(0, 0, 0, 0x1, 0) = -1 EINVAL (Invalid argument) write(2, "kexec_load (0 segments) failed: "..., 49 kexec_load (0 segments) failed: Invalid argument ) = 4 --------------------------------------------------------
This is patch to fix the problem, I think kernel code had a typo where in: if((flags & KEXEC_ARCH_MASK) == KEXEC_ARCH) was used instead of if((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH)
This patch takes care of that, I have tested the patch it worked fine for me. Please review the patch and let me know of your views. This patch is based on linux-2.6.26-rc3.
Thanks Yeehaw
Index: linux-2.6.25.3-2/kernel/kexec.c =================================================================== --- linux-2.6.25.3-2.orig/kernel/kexec.c 2008-05-23 14:57:08.000000000 +0530 +++ linux-2.6.25.3-2/kernel/kexec.c 2008-05-23 15:00:41.000000000 +0530 @@ -1068,7 +1068,8 @@ /* Don't allow clients that don't understand the native * architecture to do anything. */ - if ((flags & KEXEC_ARCH_MASK) == KEXEC_ARCH_DEFAULT) + if (((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH) && + ((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH_DEFAULT)) return -EINVAL; if (nr_segments > KEXEC_SEGMENT_MAX) | |