Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH 3/3, RFC] remove BKL from misc_open() | Date | Tue, 20 May 2008 01:34:11 +0200 |
| |
Since all misc drivers that have an open() function now take the BKL in there, there is no longer the need to take it in the common misc_open() function.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
--- Index: linux-2.6/drivers/char/misc.c =================================================================== --- linux-2.6.orig/drivers/char/misc.c +++ linux-2.6/drivers/char/misc.c @@ -50,7 +50,6 @@ #include <linux/device.h> #include <linux/tty.h> #include <linux/kmod.h> -#include <linux/smp_lock.h> /* * Head entry for the doubly linked miscdevice list @@ -121,7 +120,6 @@ static int misc_open(struct inode * inod int err = -ENODEV; const struct file_operations *old_fops, *new_fops = NULL; - lock_kernel(); mutex_lock(&misc_mtx); list_for_each_entry(c, &misc_list, list) { @@ -159,7 +157,6 @@ static int misc_open(struct inode * inod fops_put(old_fops); fail: mutex_unlock(&misc_mtx); - unlock_kernel(); return err; }
| |