lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, RFC] Char dev BKL pushdown v2
I wrote:
> Jonathan Corbet wrote:
>> drivers/ieee1394/dv1394.c | 6 +++-
>> drivers/ieee1394/raw1394.c | 3 ++
>> drivers/ieee1394/video1394.c | 18 +++++++++---
> ...
>> ieee1394: cdev lock_kernel() pushdown
>
> I have yet to look at these drivers in detail whether they need BKL or
> not. They likely don't.

video1394 needs it to serialize module init vs. open. The race
condition there can be prevented by splitting hpsb_register_highlevel()
into an _init and a _register function. I will follow up with a patch.

dv1394 and raw1394 do not need the BKL in their open() methods AFAICS.
--
Stefan Richter
-=====-==--- -=-= =--==
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2008-05-19 21:31    [W:0.058 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site