Messages in this thread | | | Subject | Re: [PATCH, RFC] Char dev BKL pushdown v2 | From | (Jonathan Corbet) | Date | Mon, 19 May 2008 07:37:58 -0600 |
| |
Roland Dreier <rdreier@cisco.com> wrote:
> Is the plan that we have a pure "push the BKL down" changeset merged, > and then I can merge BKL removal patches for these places that never > needed the BKL? (I guess I can send you such a patch to base on top of > your tree for when Linus pulls it? Is 2.6.27 the plan?)
If you're sure that this code doesn't need the BKL (and it kind of looked that way to me), the preferred approach seems to be to put in a comment to that effect so that it's clear that the code has been looked at. So sending me a patch which does this would be great. Otherwise, if you're willing to swear on top of a stack of Knuth output that the BKL is not needed for specific open functions, I can revert my patch back out and put in the comment - whichever you prefer.
jon
| |