lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 3/6] drivers/net: remove null pointer dereference
From: Julia Lawall <julia@diku.dk>

If dev is NULL, it is not possible to access its name field. So I have
simply modified the error message to drop the printing of the name field.


This problem was found using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@

* if (E == NULL)
{
... when != if (E == NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---

diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
--- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200
+++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200
@@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int
struct net_device *dev = (struct net_device *) dev_id;

if (dev == NULL) {
- printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
+ printk(KERN_ERR "isr: null dev ptr\n");
return IRQ_RETVAL(1);
}


\
 
 \ /
  Last update: 2008-05-12 15:41    [W:0.093 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site