lkml.org 
[lkml]   [2008]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[2.6.24] [Q] x86: clear DF before calling signal handler II.
Hi LKML!

Im mainline e40cd10ccff3d9fbffd57b93780bee4b7b9bff51 commit
( x86: clear DF before calling signal handler ) changed the ~TF_MASK and
~X86_EFLAGS_TF to ~(~X86_EFLAGS_TF | ~X86_EFLAGS_DF).

include/asm-x86/signal.h:
-------------------------->
248 #define ptrace_signal_deliver(regs, cookie) \
249 do { \
250 if (current->ptrace & PT_DTRACE) { \
251 current->ptrace &= ~PT_DTRACE; \
252 (regs)->eflags &= ~TF_MASK; \ <-----------
253 } \
254 } while (0)
<-------------------------

Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>

the question:
in this file the change is unnecessary or forgotted?

NO COMPILE TESTED!

---

diff --git a/include/asm-x86/signal.h b/include/asm-x86/signal.h
index 987a422..71effa1 100644
--- a/include/asm-x86/signal.h
+++ b/include/asm-x86/signal.h
@@ -249,7 +249,7 @@ struct pt_regs;
do { \
if (current->ptrace & PT_DTRACE) { \
current->ptrace &= ~PT_DTRACE; \
- (regs)->eflags &= ~TF_MASK; \
+ (regs)->eflags &= ~(TF_MASK | X86_EFLAGS_DF); \
} \
} while (0)


--
Thanks,
Oliver


\
 
 \ /
  Last update: 2008-05-10 22:35    [W:0.022 / U:1.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site