Messages in this thread Patch in this message | | | Date | Sat, 10 May 2008 12:45:09 +0400 | From | Cyrill Gorcunov <> | Subject | [PATCH] eCryptFS: fix imbalanced mutex locking |
| |
Fix imbalanced calls for mutex lock/unlock on ecryptfs_daemon_hash_mux
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> ---
Revealed by Ingo Molnar: http://lkml.org/lkml/2008/5/7/260
Please test and rewview
Index: linux-2.6.git/fs/ecryptfs/miscdev.c =================================================================== --- linux-2.6.git.orig/fs/ecryptfs/miscdev.c 2008-04-29 22:56:53.000000000 +0400 +++ linux-2.6.git/fs/ecryptfs/miscdev.c 2008-05-10 12:40:22.000000000 +0400 @@ -257,12 +257,14 @@ ecryptfs_miscdev_read(struct file *file, mutex_lock(&daemon->mux); if (daemon->flags & ECRYPTFS_DAEMON_ZOMBIE) { rc = 0; + mutex_unlock(&ecryptfs_daemon_hash_mux); printk(KERN_WARNING "%s: Attempt to read from zombified " "daemon\n", __func__); goto out_unlock_daemon; } if (daemon->flags & ECRYPTFS_DAEMON_IN_READ) { rc = 0; + mutex_unlock(&ecryptfs_daemon_hash_mux); goto out_unlock_daemon; } /* This daemon will not go away so long as this flag is set */
| |