lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch, -git] input: CONFIG_INPUT_APANEL build fix
On Wed, Apr 30, 2008 at 10:56:05PM +0200, Roman Zippel wrote:
> Hi,
>
> On Wed, 30 Apr 2008, Ingo Molnar wrote:
>
> > > Thank you Ingo. Isn't this a Kconfig issue though? I know that Roman
> > > is not willing to fix SELECT to evaluate the whole dependency chain,
> > > but in this case it is "depens on" that does not evaluate properly...
> >
> > yes and no. It can be fixed in Kconfig but i'm not going to flame yet
> > another person about long-existing unfixed infrastructure bugs ;-)
>
> You don't have to, because this simply is no infrastructure bug...
> Don't blame Kconfig for abusing select for something it was never
> intendend for. There is no bug!
>

That is all fine and dandy except that apanel does not select LEDs, it
depends on LEDS_CLASS.

> In this case there is now a mixture of depends and selects on leds. First
> decide whether led support should be automatically included or the driver
> is only available when led support is enabled. In the first case it's
> probably better to create LEDS_SUPPORT, which then again selects
> everything necessary.
>

The decision is made, the driver depends on LEDs except that it is not
working.

--
Dmitry


\
 
 \ /
  Last update: 2008-05-01 00:25    [W:2.542 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site