Messages in this thread Patch in this message | | | Date | Wed, 23 Apr 2008 22:55:16 +0200 | From | Roel Kluin <> | Subject | [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() |
| |
mpc83xx_spi->irq is unsigned, so the test fails
Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c index be15a62..033fd51 100644 --- a/drivers/spi/spi_mpc83xx.c +++ b/drivers/spi/spi_mpc83xx.c @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev) goto put_master; } - mpc83xx_spi->irq = platform_get_irq(dev, 0); - - if (mpc83xx_spi->irq < 0) { - ret = -ENXIO; + ret = platform_get_irq(dev, 0); + if (ret < 0) goto unmap_io; - } + + mpc83xx_spi->irq = ret; + ret = 0; /* Register for SPI Interrupt */ ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
| |