Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() | Date | Wed, 23 Apr 2008 15:39:32 -0500 |
| |
On Apr 23, 2008, at 3:19 PM, Roel Kluin wrote: > mpc83xx_spi->irq is unsigned, so the test fails > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
you should copy the linux-spi list on such patches.
- k
> > --- > diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c > index be15a62..033fd51 100644 > --- a/drivers/spi/spi_mpc83xx.c > +++ b/drivers/spi/spi_mpc83xx.c > @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct > platform_device *dev) > goto put_master; > } > > - mpc83xx_spi->irq = platform_get_irq(dev, 0); > - > - if (mpc83xx_spi->irq < 0) { > - ret = -ENXIO; > + ret = platform_get_irq(dev, 0); > + if (ret < 0) > goto unmap_io; > - } > + > + mpc83xx_spi->irq = ret; > + ret = 0; > > /* Register for SPI Interrupt */ > ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
| |