lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 2/2 v2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe()
Joe Perches wrote:
> On Wed, 2008-04-23 at 22:55 +0200, Roel Kluin wrote:

>> - xspi->irq = platform_get_irq(dev, 0);
>> - if (xspi->irq < 0) {
>> - ret = -ENXIO;
>> + ret = platform_get_irq(dev, 0);
>> + if (ret < 0)
>> goto unmap_io;
>> - }
>> +
>> + xspi->irq = ret;
>> + ret = 0;
>
> Is the only negative return from platform_get_irq ENXIO?
> I think you still need the ret = -ENXIO before the goto.
>
> Also, you don't need the ret = 0 line, it's set again
> a few lines below.
>
> I think you should end up with:
>
> ret = platform_get_irq(dev, 0);
> if (ret < 0) {
> ret = -ENXIO;
> goto unmap_io;
> }
>
> xspi->irq = ret;
>
> cheers, Joe

In that case, this should suffice,

thanks again,

Roel
---
xilinx_spi->irq is unsigned, so the test fails

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
index cf6aef3..2a471b3 100644
--- a/drivers/spi/xilinx_spi.c
+++ b/drivers/spi/xilinx_spi.c
@@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev)
goto put_master;
}

- xspi->irq = platform_get_irq(dev, 0);
- if (xspi->irq < 0) {
+ ret = platform_get_irq(dev, 0);
+ if (ret < 0) {
ret = -ENXIO;
goto unmap_io;
}
+ xspi->irq = ret;

master->bus_num = pdata->bus_num;
master->num_chipselect = pdata->num_chipselect;

\
 
 \ /
  Last update: 2008-04-24 09:39    [W:0.040 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site