lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix brd allocation flags
On Thu, Apr 17, 2008 at 11:14:07PM +0200, Petr Tesarik wrote:
> Hello,
>
> while looking at the implementation of the Ram backed block device
> driver, I stumbled across a write-only local variable, which makes
> little sense, so I assume it should actually work like this:

Right you are. Good catch, thanks Petr.

>
> Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 8536480..7bd7663 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector)
> #ifndef CONFIG_BLK_DEV_XIP
> gfp_flags |= __GFP_HIGHMEM;
> #endif
> - page = alloc_page(GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO);
> + page = alloc_page(gfp_flags);
> if (!page)
> return NULL;
>


\
 
 \ /
  Last update: 2008-04-22 05:37    [W:0.225 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site