Messages in this thread Patch in this message | | | Subject | [PATCH] fix brd allocation flags | From | Petr Tesarik <> | Date | Thu, 17 Apr 2008 23:14:07 +0200 |
| |
Hello,
while looking at the implementation of the Ram backed block device driver, I stumbled across a write-only local variable, which makes little sense, so I assume it should actually work like this:
Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 8536480..7bd7663 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector) #ifndef CONFIG_BLK_DEV_XIP gfp_flags |= __GFP_HIGHMEM; #endif - page = alloc_page(GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO); + page = alloc_page(gfp_flags); if (!page) return NULL;
| |