lkml.org 
[lkml]   [2008]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)
Hi Bryan,

On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote:
> + input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) |
> + BIT_MASK(BTN_BASE2) |
> + BIT_MASK(BTN_BASE3) |
> + BIT_MASK(BTN_BASE4);
> + input->keybit[BIT_WORD(KEY_UP)] |= BIT_MASK(KEY_UP) |
> + BIT_MASK(KEY_DOWN) |
> + BIT_MASK(KEY_LEFT) |
> + BIT_MASK(KEY_RIGHT);
> +

Why don't you use REL_X/REL_Y to report directional movement? Using
buttons for that is pretty unusual.

--
Dmitry


\
 
 \ /
  Last update: 2008-04-18 19:19    [W:0.065 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site