Messages in this thread | | | Date | Fri, 18 Apr 2008 13:15:58 -0400 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) |
| |
Hi Bryan,
On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote: > + input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) | > + BIT_MASK(BTN_BASE2) | > + BIT_MASK(BTN_BASE3) | > + BIT_MASK(BTN_BASE4); > + input->keybit[BIT_WORD(KEY_UP)] |= BIT_MASK(KEY_UP) | > + BIT_MASK(KEY_DOWN) | > + BIT_MASK(KEY_LEFT) | > + BIT_MASK(KEY_RIGHT); > +
Why don't you use REL_X/REL_Y to report directional movement? Using buttons for that is pretty unusual.
-- Dmitry
| |