Messages in this thread | | | Date | Fri, 25 Apr 2008 18:09:52 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) |
| |
On Sat, Apr 19, 2008 at 1:15 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > Hi Bryan, > > > On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote: > > + input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) | > > + BIT_MASK(BTN_BASE2) | > > + BIT_MASK(BTN_BASE3) | > > + BIT_MASK(BTN_BASE4); > > + input->keybit[BIT_WORD(KEY_UP)] |= BIT_MASK(KEY_UP) | > > + BIT_MASK(KEY_DOWN) | > > + BIT_MASK(KEY_LEFT) | > > + BIT_MASK(KEY_RIGHT); > > + > > Why don't you use REL_X/REL_Y to report directional movement? Using > buttons for that is pretty unusual. >
In our development board, it includes UP/DOWN/LEFT/RIGHT 4 buttons. So this driver matches this. Please found some information about the hardware as below: http://docs.blackfin.uclinux.org/doku.php?id=capacitance_touch_sensors&s[]=ad7142
Thanks -Bryan
| |