Messages in this thread | | | Date | Tue, 15 Apr 2008 14:37:56 +0300 (EEST) | From | "Ilpo Järvinen" <> | Subject | Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h |
| |
On Tue, 15 Apr 2008, Adrian Bunk wrote:
> On Tue, Apr 15, 2008 at 02:10:57AM -0700, Andrew Morton wrote: > > On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote: > > > > > > +#include <linux/time.h> > > > > Did this actually cause a compilation error? > > Even if it doesn't at the moment it should be fixed - these kind > of issues are why often adding or removing an #include in a header > suddenly breaks some configuration on some other architecture.
...I suppose point of Andrew's enquiry was more about determining how soon it should be scheduled for inclusion rather than its usefulness.
-- i.
| |