lkml.org 
[lkml]   [2008]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h
On Tue, 15 Apr 2008, Andrew Morton wrote:

> On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote:
>
> >
> > Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@helsinki.fi>
> > ---
> > include/linux/smb.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/smb.h b/include/linux/smb.h
> > index f098dff..caa43b2 100644
> > --- a/include/linux/smb.h
> > +++ b/include/linux/smb.h
> > @@ -11,6 +11,7 @@
> >
> > #include <linux/types.h>
> > #include <linux/magic.h>
> > +#include <linux/time.h>
> >
> > enum smb_protocol {
> > SMB_PROTOCOL_NONE,
>
> Did this actually cause a compilation error?

No and yes, none I know of in mainline but with my uninlining tool, if
that counts :-), it did until I work-around the number of compilation
failures I got if I just include a single header file to a uninlined.c by
taking an existing compilation unit's list of headers (and hoping for the
best), which worked most of time (this case include). ...I'm not sure
should they all be fixed or not (not to speak of how). Finding most of
them seems relatively easy to automate by include alone + compile.


--
i.


\
 
 \ /
  Last update: 2008-04-15 11:23    [W:0.077 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site