Messages in this thread | | | Date | Sun, 13 Apr 2008 21:53:29 +0200 | From | "Jesper Juhl" <> | Subject | Re: [2.6 patch] mfd/sm501.c: #if 0 unused functions |
| |
On 13/04/2008, Adrian Bunk <bunk@kernel.org> wrote: > On Sun, Apr 13, 2008 at 09:34:24PM +0200, Jesper Juhl wrote: > >... > > Please don't see my comments as complaints. They are not intended as > > such. I'm merely currious why we keep adding all these '#if 0's since > > I don't see the point and I can just see them piling up into some huge > > janitorial mountain from hell to be tackled some time in the future by > > whomever is masochistic enough to try ;-) > > > The main advantage of the #if 0 solution is that it not only stops > bloating the kernel image, but in the frequent "I might need it some day" > case I can simply say "no problem with my patch - just remove the #if 0". > Heh, and in the mean time I'm tempted to submit a huge patch removing all code within #if 0 #endif outright. Just to get rid of all the useless code we are carrying around from release to release. Those 2168 '#if 0' blocks amount to quite a lot of code^d^d^d^dcomments and most of it is just useless... But, before I attempt that I need to go and buy new flame proof underwear.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html
| |