lkml.org 
[lkml]   [2008]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] mfd/sm501.c: #if 0 unused functions
On Sun, Apr 13, 2008 at 09:34:24PM +0200, Jesper Juhl wrote:
>...
> Please don't see my comments as complaints. They are not intended as
> such. I'm merely currious why we keep adding all these '#if 0's since
> I don't see the point and I can just see them piling up into some huge
> janitorial mountain from hell to be tackled some time in the future by
> whomever is masochistic enough to try ;-)

The main advantage of the #if 0 solution is that it not only stops
bloating the kernel image, but in the frequent "I might need it some day"
case I can simply say "no problem with my patch - just remove the #if 0".

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-04-13 21:57    [W:1.011 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site