Messages in this thread | | | Subject | Re: [PATCH -mm 2/4] x86_64 boot: Add linked list of struct setup_data | From | "Huang, Ying" <> | Date | Fri, 28 Mar 2008 10:08:37 +0800 |
| |
On Thu, 2008-03-27 at 06:25 -0500, Paul Jackson wrote: > Huang wrote: > + while (pa_data) { > + data = early_ioremap(pa_data, PAGE_SIZE); > + switch (data->type) { > + default: > + break; > + } > > Isn't that switch statement equivalent to -always- breaking, as in: > > + while (pa_data) { > + data = early_ioremap(pa_data, PAGE_SIZE); > + break; > > I doubt you want to do that. I suppose what you want to do is check for > data == NULL instead, as in: > > + while (pa_data) { > + data = early_ioremap(pa_data, PAGE_SIZE); > + if (!data) > + break;
This break will break the switch instead of while. When setup_data processing code is added, the code will looks like:
#define SETUP_DATA_E820_EXT 1
while (pa_data) { data = early_ioremap(pa_data, PAGE_SIZE); switch (data->type) { case SETUP_DATA_E820_EXT: parse_e820_ext(data, pa_data); break; default: break; } ...
Best Regards, Huang Ying
| |