lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 2/4] x86_64 boot: Add linked list of struct setup_data
Huang wrote:
+ while (pa_data) {
+ data = early_ioremap(pa_data, PAGE_SIZE);
+ switch (data->type) {
+ default:
+ break;
+ }

Isn't that switch statement equivalent to -always- breaking, as in:

+ while (pa_data) {
+ data = early_ioremap(pa_data, PAGE_SIZE);
+ break;

I doubt you want to do that. I suppose what you want to do is check for
data == NULL instead, as in:

+ while (pa_data) {
+ data = early_ioremap(pa_data, PAGE_SIZE);
+ if (!data)
+ break;

???

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214


\
 
 \ /
  Last update: 2008-03-27 12:29    [W:0.043 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site