Messages in this thread | | | Date | Thu, 27 Mar 2008 08:56:53 +0100 | From | Stefan Richter <> | Subject | Re: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler |
| |
I wrote: > I wrote: >> On the other hand, why do we free a page + allocate a page? >> Why don't we re-initialize and re-add the old page? > > Meanwhile I tried a simple modification to ar_context_add_page and its > callers which results in _add_page simply re-adding the old page. I must > do something fundamentally wrong though.
Besides, the current code which reassembles packets that reach into the next buffer is broken for packets whose total size approaches PAGE_SIZE. (Remember, async packets can be sized 4kB + 1394 headers + OHCI trailer.) Reminds me of ohci1394 somehow. :-(
I will attempt to fix this for post 2.6.25, unless you aspire to do so. -- Stefan Richter -=====-==--- --== ==-== http://arcgraph.de/sr/
| |