Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler | Date | Wed, 26 Mar 2008 09:09:49 -0400 |
| |
On Wednesday 26 March 2008 03:09:47 am Stefan Richter wrote: > Jarod Wilson wrote: > > @@ -605,7 +606,7 @@ static void ar_context_tasklet(unsigned long data) > > buffer = handle_ar_packet(ctx, buffer); > > > > dma_free_coherent(ohci->card.device, PAGE_SIZE, > > - buffer, buffer_bus); > > + start, start_bus); > > ar_context_add_page(ctx); > > On the other hand, why do we free a page + allocate a page? > Why don't we re-initialize and re-add the old page?
Oh good, I'm not crazy (outside of having firewire on the brain way too much right now). I had that same thought tossing and turning in bed late last night. :)
-- Jarod Wilson jwilson@redhat.com
| |