lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler
Date
On Wednesday 26 March 2008 03:09:47 am Stefan Richter wrote:
> Jarod Wilson wrote:
> > @@ -605,7 +606,7 @@ static void ar_context_tasklet(unsigned long data)
> > buffer = handle_ar_packet(ctx, buffer);
> >
> > dma_free_coherent(ohci->card.device, PAGE_SIZE,
> > - buffer, buffer_bus);
> > + start, start_bus);
> > ar_context_add_page(ctx);
>
> On the other hand, why do we free a page + allocate a page?
> Why don't we re-initialize and re-add the old page?

Oh good, I'm not crazy (outside of having firewire on the brain way too much
right now). I had that same thought tossing and turning in bed late last
night. :)

--
Jarod Wilson
jwilson@redhat.com


\
 
 \ /
  Last update: 2008-03-26 14:13    [W:0.049 / U:1.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site