Messages in this thread | | | Date | Sun, 23 Mar 2008 14:10:17 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [patch 0/4] x86 - relocate_kernel cleanup |
| |
[H. Peter Anvin - Sat, Mar 22, 2008 at 02:18:49PM -0700] > H. Peter Anvin wrote: >> gorcunov@gmail.com wrote: >>> The main purpose of this patches is to eliminate numeric constant and >>> use predefined macroses. Please review. I've tested 64bit version on >>> object level - it remains the same. Any comments are welcome. >> Looks good. Since you're doing work in this realm, you may also want to >> replace the old TF_MASK etc macros with X86_EFLAGS_TF etc. > > That wasn't meant to be a comment specific to the relocate_kernel stuff, > incidentally. > > -hpa >
You know, Peter, I'm a bit scared that these flags are in number of files and could break others queued patches...
- Cyrill -
| |