lkml.org 
[lkml]   [2008]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 0/4] x86 - relocate_kernel cleanup
H. Peter Anvin wrote:
> gorcunov@gmail.com wrote:
>> The main purpose of this patches is to eliminate numeric constant and
>> use predefined macroses. Please review. I've tested 64bit version on
>> object level - it remains the same. Any comments are welcome.
>
> Looks good. Since you're doing work in this realm, you may also want to
> replace the old TF_MASK etc macros with X86_EFLAGS_TF etc.

That wasn't meant to be a comment specific to the relocate_kernel stuff,
incidentally.

-hpa


\
 
 \ /
  Last update: 2008-03-22 22:23    [W:0.069 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site