Messages in this thread |  | | Date | Sat, 22 Mar 2008 14:18:49 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [patch 0/4] x86 - relocate_kernel cleanup |
| |
H. Peter Anvin wrote: > gorcunov@gmail.com wrote: >> The main purpose of this patches is to eliminate numeric constant and >> use predefined macroses. Please review. I've tested 64bit version on >> object level - it remains the same. Any comments are welcome. > > Looks good. Since you're doing work in this realm, you may also want to > replace the old TF_MASK etc macros with X86_EFLAGS_TF etc.
That wasn't meant to be a comment specific to the relocate_kernel stuff, incidentally.
-hpa
|  |