lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] PPS: serial clients support.
On Fri, 21 Mar 2008 12:17:36 +0100 Rodolfo Giometti <giometti@enneenne.com> wrote:

> > > +#else
> > > +
> > > +#define uart_register_pps_port(state, port) do { } while (0)
> > > +#define uart_unregister_pps_port(state, port) do { } while (0)
> >
> > Please never implement in cpp that which can be implemented in C. These
> > should have been static inlines. That's nicer, matches the
> > CONFIG_PPS_CLIENT_UART=y code and provides type checking.
>
> Are you saying that I should do:
>
> static inline int
> uart_register_pps_port(struct uart_state *state, struct uart_port *port)
> {
> /* Nop */
> }
>
> static inline void
> uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
> {
> /* Nop */
> }
>
> ?

Yes please.


\
 
 \ /
  Last update: 2008-03-21 18:47    [W:0.050 / U:2.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site